Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVELOPER-691 Update global.scss #284

Merged
merged 2 commits into from Jun 17, 2014
Merged

DEVELOPER-691 Update global.scss #284

merged 2 commits into from Jun 17, 2014

Conversation

pmuir
Copy link
Contributor

@pmuir pmuir commented Jun 16, 2014

  • make Magnolia and Jive consistent with Developer
  • also remove the “http:” from static url’s to avoid issues with
    “https:”

@jboss-developer-ci
Copy link
Contributor

Triggering build using a merge of beb857d on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/

@pmuir pmuir mentioned this pull request Jun 16, 2014
Closed
@pmuir
Copy link
Contributor Author

pmuir commented Jun 16, 2014

Replaces #276

@jboss-developer-ci
Copy link
Contributor

Build 113 is now running using a merge of beb857d on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/113

@jboss-developer-ci
Copy link
Contributor

Build 113 outcome was success using a merge of beb857d on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/113
Preview: http://www-stg.jboss.org/pr/284/build/113

@pmuir
Copy link
Contributor Author

pmuir commented Jun 16, 2014

@cheyenneweaver I am getting two errors from the build now, which we should resolve before merging:

WARNING on line 256 of /Users/pmuir/workspace/www.jboss.org/stylesheets/_global-wrapper.scss: "i.jd-redhat:before" failed to @extend ".icons-redhat".
  The selector ".icons-redhat" was not found.
  This will be an error in future releases of Sass.
  Use "@extend .icons-redhat !optional" if the extend should be able to fail.

WARNING on line 343 of /Users/pmuir/workspace/www.jboss.org/stylesheets/_global-wrapper.scss: "ul.footer-nav li.redhat a" failed to @extend ".icons-redhat-logo".
  The selector ".icons-redhat-logo" was not found.
  This will be an error in future releases of Sass.
  Use "@extend .icons-redhat-logo !optional" if the extend should be able to fail.

@pmuir
Copy link
Contributor Author

pmuir commented Jun 16, 2014

retest this please

@jboss-developer-ci
Copy link
Contributor

Triggering build using a merge of a0126e4 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/

@jboss-developer-ci
Copy link
Contributor

Build 115 is now running using a merge of a0126e4 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/115

@jboss-developer-ci
Copy link
Contributor

Build 115 outcome was success using a merge of a0126e4 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/115
Preview: http://www-stg.jboss.org/pr/284/build/115

@cheyenneweaver @pmuir
DEVELOPER-691 Update global.scss
1b46090 
- make Magnolia and Jive consistent with Developer
- also remove the “http:” from static url’s to avoid issues with
“https:”
@jboss-developer-ci
Copy link
Contributor

Triggering build using a merge of 586c507 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/

@jboss-developer-ci
Copy link
Contributor

Build 119 is now running using a merge of 586c507 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/119

@jboss-developer-ci
Copy link
Contributor

Build 119 outcome was success using a merge of 586c507 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/119
Preview: http://www-stg.jboss.org/pr/284/build/119

@jboss-developer-ci
Copy link
Contributor

Triggering build using a merge of ceea9a2 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/

@jboss-developer-ci
Copy link
Contributor

Build 123 is now running using a merge of ceea9a2 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/123

@jboss-developer-ci
Copy link
Contributor

Build 123 outcome was success using a merge of ceea9a2 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/www.jboss.org-pull-player-executor/123
Preview: http://www-stg.jboss.org/pr/284/build/123

pmuir pushed a commit that referenced this pull request Jun 17, 2014
Merge pull request #284 from pmuir/DEVELOPER-691
faa46eb 
DEVELOPER-691 Update global.scss
@pmuir pmuir merged commit faa46eb into jboss-developer:master Jun 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pmuir @jboss-developer-ci @cheyenneweaver