DEVELOPER-911 - present a banner when coming from jdf-site@openshift #456
Conversation
|
Can one of the admins verify this patch? |
|
ok to test |
|
Triggering build using a merge of 5499934 on branch master: |
|
Build 599 is now running using a merge of 5499934 on branch master: |
|
Build 599 outcome was success using a merge of 5499934 on branch master: |
| @@ -1,6 +1,7 @@ | |||
| --- | |||
| layout: get-started-base | |||
| --- | |||
| = partial 'jdf_advise.html.slim', {'parent' => page} | |||
There was a problem hiding this comment.
Advise or advertise? You called the JS one thing, the partial another.
There was a problem hiding this comment.
Good catch! I'll fix that!
|
What is the best way to trigger this manually to see it in action? |
|
Triggering build using a merge of 49938f4 on branch master: |
|
Build 605 is now running using a merge of 49938f4 on branch master: |
|
It's ready for review again. |
|
Build 605 outcome was failure using a merge of 49938f4 on branch master: |
|
retest this please |
|
Triggering build using a merge of 49938f4 on branch master: |
|
Build 610 is now running using a merge of 49938f4 on branch master: |
|
Build 610 outcome was success using a merge of 49938f4 on branch master: |
| a(href="#" onClick="app.jdf.hideAdvise();") | ||
| h2#title JDF - JBoss Developer Framework is now JBoss Developer Materials | ||
| p | ||
| |You can find all content (Quickstarts, Archetypes, BOMs), and much more materials that we provide for developers to get coding quickly at this page. Enjoy! |
There was a problem hiding this comment.
It's "many more" not "much more". At this page -> here.
|
Triggering build using a merge of a146e8f on branch master: |
|
Build 633 is now running using a merge of a146e8f on branch master: |
|
Triggering build using a merge of cb42d55 on branch master: |
|
Build 634 is now running using a merge of cb42d55 on branch master: |
|
Build 634 outcome was success using a merge of cb42d55 on branch master: |
| a(href="#" onClick="app.jdf.hideAdvise();") | ||
| h2#title JDF - JBoss Developer Framework is now JBoss Developer Materials | ||
| p | ||
| |You can find all content (Quickstarts, Archetypes, BOMs), and many more materials that we provide for developers to get coding quickly at this page. Enjoy! |
There was a problem hiding this comment.
Damn, just realised it should be "all the old content". Maybe "many new" rather than "many more"
|
Triggering build using a merge of 164c500 on branch master: |
|
Build 639 is now running using a merge of 164c500 on branch master: |
|
Build 639 outcome was success using a merge of 164c500 on branch master: |
|
Triggering build using a merge of 03b555d on branch master: |
|
Build 640 is now running using a merge of 03b555d on branch master: |
|
Build 640 outcome was success using a merge of 03b555d on branch master: |
|
retest this please |
|
Triggering build using a merge of 03b555d on branch master: |
|
Build 642 is now running using a merge of 03b555d on branch master: |
|
Build 642 outcome was success using a merge of 03b555d on branch master: |
DEVELOPER-911 - present a banner when coming from jdf-site@openshift
No description provided.