Jira SO-53: Remove non-groupified API from jboss-fuse/application-templates #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plates Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
/assign @yselkowitz |
|
Templates contain subsidiary objects which themselves have apiVersions which also need to be updated, e.g. Route v1 => route.openshift.io, etc. Only those listed here as |
…plates Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
/cc @yselkowitz Updated the PR accordingly |
yselkowitz
reviewed
May 13, 2022
fis-image-streams.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "kind": "List", | |||
| "apiVersion": "v1", | |||
| "apiVersion": "image.openshift.io/v1", | |||
Updated the List Api as v1
|
Looks good to me, but |
|
Ultimately, we need this in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-groupified APIs were deprecated in OCP 4.7.
This PR only handles the imagestreams/Templates which are bundled in OpenShift. If any of the other imagestreams or templates are meant to still be used, they should also be similarly updated. A complete API list is available at https://docs.openshift.com/container-platform/4.10/rest_api/index.html .
Signed-off-by: Feny Mehta fbm3307@gmail.com