ENTESB-11929: [ER1][OCP4][SB1] Watching configmap throws exception #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Kubernetes URL used doesn't specify a port (e.g., https://example.com/api/v1/...), the origin header for watch requests ends up with a port of -1 (e.g. https://example.com:-1). This happens because calling `getPort()` on a java.net.URL object that does not have a port explicitly specified will always return -1. The return value was always just inserted into the origin header. Now, we check for this and only append a port to the origin header if `getPort()` returns something other than -1. We make this change in both the WatchConnectionManager and WatchHTTPManager classes.
nicolaferraro
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for port before setting Origin header for watch requests.
When the Kubernetes URL used doesn't specify a port
(e.g., https://example.com/api/v1/...), the origin header for
watch requests ends up with a port of -1 (e.g. https://example.com:-1).
This happens because calling
getPort()on a java.net.URL object thatdoes not have a port explicitly specified will always return -1. The
return value was always just inserted into the origin header.
Now, we check for this and only append a port to the origin header if
getPort()returns something other than -1. We make this change in boththe WatchConnectionManager and WatchHTTPManager classes.