Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

[WebView]blank column on each side #69

Closed
apupier opened this issue Feb 11, 2019 · 1 comment
Closed

[WebView]blank column on each side #69

apupier opened this issue Feb 11, 2019 · 1 comment

Comments

@apupier
Copy link
Member

apupier commented Feb 11, 2019 •
edited

follow-up of atlasmap/atlasmap#749

image

I check that it is displayed well in Chrome with the same instance:
image
@apupier
Copy link
Member Author

apupier commented Feb 11, 2019

@igarashitm @pleacu

If we replace <body> by <body style="padding: 0"> apupier#2 it is displayed correctly.
is it a good solution? Will it not break something else?

VS Code is providing several defaults css rules:
https://github.com/Microsoft/vscode/blob/35523f6c51bdc1edae1696a586dadd021fe47096/src/vs/workbench/contrib/webview/electron-browser/webview-pre.js#L412-L466

how to know which one will affect AtlasMap UI?

initially asked here atlasmap/atlasmap#749 (comment)

@apupier apupier mentioned this issue Feb 11, 2019
Closed
apupier referenced this issue in apupier/vscode-atlasmap Feb 15, 2019
@apupier
Override padding style from VS Code to match AtlasMap one #69
b2ba5fd 
it allows to take the whole space in UI

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Feb 18, 2019
Closed
apupier added a commit that referenced this issue Feb 21, 2019
@apupier
Override padding style from VS Code to match AtlasMap one #69
7b0ac33 
it allows to take the whole space in UI

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier closed this as completed Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apupier