fixed JASSIST-267 (new )

[NingZhang-e]

To fix JASSIST-267. Please kindly help review.

This is a replacement of #142 due to my organization suggest me use a new Github account.

[nickl-]

Much better than $142 nice one!

I would just revisit that funky for loop and make it more readable. Reduce the "What the?!?!" factor =)

Otherwise it seems you've hit the nail on the head, well done!

Note: I did not actually test the proposal.

[nickl-]

this is weird =/ why not just use a normal for statement with the i counter then?

[NingZhang-e]

Code cleaned. Please check the new change.

[nickl-]

Nice! Looks good! Will see if I can get a moment to test.

[NingZhang-e]

@nickl- Do you have time checking it?

[nickl-]

@NingZhang-Ericsson oh crap, I forgot about this but also haven't had a moment free to look at anything else.

You do know that I am not here at javassist in any official capacity, just to be clear. I don't mind helping out where I can but have commitments at other projects that takes priority. Besides @chibash is the one that needs to accept or reject this I can only say that I agree with you.

That said I did say I will test it for you so I will make some time to do that. Thank you for the reminder.

[nickl-]

Tested and works as advertised.

Well done @NingZhang-Ericsson, nice one =)

RTBC
+1

[NingZhang-e]

Great thanks to @nickl- !

@chibash Chiba-san, would you like to check with it?

[NingZhang-e]

Hi,
@chibash, do you have any comment on this PR? Accept or reject it?
Your opinion is really needed.

[chibash]

Can you briefly explain differences between #142 and #267 with respect to how to fix JASSIST-267?

[NingZhang-e]

#210
Change isOverloaded() to isDuplicated() is more precise and easier to understand. Because #267 is introduced by overloaded method. And it fixed the issue on the early stage as possible.
#142
I added one method called as isBridgeAndOverloadedAndPublic() which is a little confusing(too long method name), although it fixed #267, but it is a little hard to understand and maintain.

Hope I have explained the difference. :-)

[chibash]

Thank you for fixing JASSIST-267.

[Elisedlund]

Nice!
We BTW open sourced our interception library that had issues with this bug. the library lets you manipulate existing objects and classes behavior runtime, It's achieving this by using javassist
example:

    //lambda on class
        SomeImpl obj = with(SomeImpl.class)
                .interceptAll(i -> {
                    System.out.println("before method: " + i.getMethodName() + " param: " + i.getParameter0());
                    return i.invoke();
                }).get();
        obj.log("123");
        //Console output:
        //        before method: log param: 123
        //        123


        //lambda on object
        SomeImpl obj2 = with(new SomeImpl())
                .interceptAll(i -> {
                    Object result = i.invoke();
                    System.out.println("after method: " + i.getMethodName() + " param: " + i.getParameter0());
                    return result;
                }).get();
        obj2.log("321");
        //Console output:
        //        321
        //        after method: log param: 321

lib: https://github.com/Ericsson/proxy