Remove the explicit dependency on org.jboss.logmanager and add an exp…

…licit opens to the module if it exists.

Signed-off-by: James R. Perkins <jperkins@redhat.com>

src/main/java/module-info.yml

@@ -1,8 +1,6 @@
 name: org.jboss.logging
 
 requires:
-  - module: org.jboss.logmanager
-    static: true
   - module: org.slf4j
     static: true
   - module: log4j.api # log4j 1, theoretically

src/main/java/org/jboss/logging/LoggerProviders.java

@@ -137,9 +137,17 @@ private static LoggerProvider tryLog4j(final ClassLoader cl, final String via) t
 
     private static LoggerProvider tryJBossLogManager(final ClassLoader cl, final String via) throws ClassNotFoundException {
         final Class<? extends LogManager> logManagerClass = LogManager.getLogManager().getClass();
-        if (logManagerClass == Class.forName("org.jboss.logmanager.LogManager", false, cl)
+        final Class<?> jblLogManager = Class.forName("org.jboss.logmanager.LogManager", false,
+                Logger.class.getClassLoader());
+        if (logManagerClass == jblLogManager
                 && Class.forName("org.jboss.logmanager.Logger$AttachmentKey", true, cl).getClassLoader() == logManagerClass
                         .getClassLoader()) {
+            // We do not have an explicit dependency on org.jboss.logmanager as we could end up with cyclic dependencies.
+            // Therefore, we check the modules are named, and if they are we add an explicit reads.
+            final Module module = LoggerProviders.class.getModule();
+            if (module.isNamed() && jblLogManager.getModule().isNamed()) {
+                module.addReads(jblLogManager.getModule());
+            }
             final LoggerProvider provider = new JBossLogManagerProvider();
             logProvider(provider, via);
             return provider;