Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOGMGR-238] Lightweight attachments #231

Merged
merged 1 commit into from Mar 15, 2019
Merged

[LOGMGR-238] Lightweight attachments #231

merged 1 commit into from Mar 15, 2019

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Feb 26, 2019

No description provided.

@dmlloyd dmlloyd requested a review from jamezp February 26, 2019 13:35
jamezp
jamezp approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only additional thing we may want to do is just update the java doc to indicate only 2 attachments are allowed.

core/src/main/java/org/jboss/logmanager/LogContext.java Outdated Show resolved Hide resolved
@dmlloyd dmlloyd changed the title [RFC] Lightweight attachments [LOGMGR-238] Lightweight attachments Feb 26, 2019
@jamezp jamezp merged commit 03fcfc0 into jboss-logging:master Mar 15, 2019
@dmlloyd dmlloyd deleted the attach branch March 15, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dmlloyd @jamezp