Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOGMGR-244] Log context initializer #241

Merged
merged 1 commit into from Mar 20, 2019
Merged

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Mar 20, 2019

Introduce the concept of a log context initializer, which sets the default values for loggers before the configuration is loaded. This is intended for use in the Quarkus environment where we want logging up and running instantly but we can't configure it until later (by way of DelayedHandler).

@dmlloyd dmlloyd requested a review from jamezp March 20, 2019 15:59
Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks good. Just a minor question about the privileged block and we do need to some how initialize the handler array on the LoggerNode.

@dmlloyd dmlloyd changed the title [RFC] Log context initializer [LOGMGR-244] Log context initializer Mar 20, 2019
@dmlloyd dmlloyd marked this pull request as ready for review March 20, 2019 18:29
@dmlloyd dmlloyd requested a review from jamezp March 20, 2019 18:29
@jamezp jamezp merged commit 5a93e71 into jboss-logging:master Mar 20, 2019
@dmlloyd dmlloyd deleted the init branch March 20, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants