[LOGMGR-96] Add hostname format option for the pattern formatter. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return the format step | ||
| */ | ||
| public static FormatStep hostnameFormatStep(final boolean leftJustify, final int minimumWidth, final boolean truncateBeginning, final int maximumWidth, final boolean qualified) { | ||
| final Properties props; |
There was a problem hiding this comment.
This seems like it shouldn't be done on every log message. The host name is unlikely to change very often, and even if it changed, the props and env wouldn't change with it anyway. Probably just move the detected host name out to a once-only constant.
There was a problem hiding this comment.
This actually should only be done once or done once each time the pattern is parsed into steps.
There was a problem hiding this comment.
Ah, you are correct. Guess it's been a while :)
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.