-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major issue with latest 1.2.1.Final #15
Comments
@gsmet Are you looking for a revert of the fix then a release of 1.2.2.Final with the revert? |
That could be an option :). I don't exactly know what's going wrong with this patch and why it broke user apps. |
Ah okay. Basically the issue is we've got too many abstractions. We've got slf4j -> jboss-logging -> jboss-logmanager. Since we pass the parameters to jboss-logging it passes them to jboss-logmanager. The jboss-logmanager sees the parameters and attempts to format the already formatted message resulting in the failure. I've made a change to allow https://github.com/jboss-logging/slf4j-jboss-logmanager/ to do that. My suggestion would be to use slf4j-jboss-logmanager if the jboss-logmangaer will always be the log manager. |
Could you explain to me the difference between the two artifacts so that I can take an educated decision? Thanks! |
@gsmet The difference is that the slf4j-jboss-logging delegates slf4j to jboss-logging. jboss-logging will bind to some log manager as it's a facade itself. slf4j-jboss-logmanager delegates to jboss-logmanager. So it requires the jboss-logmanager to be used as the log manager. Does that make sense? |
The 1.2.1 version of the slf4j-jboss-logging component has issues with logging statements that contain curly braces as indicated here jboss-logging/slf4j-jboss-logging#15 We therefore fall back to using the previous version as defined by Quarus 1.9.2.Final. Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
We had several people reporting issues with the latest versions of Quarkus due to the upgrade to 1.2.1.Final.
See:
I think it's probably due to this commit: 1204d43 .
We downgraded to 1.2.0.Final but we wanted 1.2.1.Final for the license change.
Any chance someone could have a look at this issue and release a 1.2.2.Final? Thanks!
The text was updated successfully, but these errors were encountered: