Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major issue with latest 1.2.1.Final #15

Closed
gsmet opened this issue Oct 13, 2020 · 5 comments · Fixed by #16
Closed

Major issue with latest 1.2.1.Final #15

gsmet opened this issue Oct 13, 2020 · 5 comments · Fixed by #16

Comments

@gsmet
Copy link

gsmet commented Oct 13, 2020

We had several people reporting issues with the latest versions of Quarkus due to the upgrade to 1.2.1.Final.

See:

I think it's probably due to this commit: 1204d43 .

We downgraded to 1.2.0.Final but we wanted 1.2.1.Final for the license change.

Any chance someone could have a look at this issue and release a 1.2.2.Final? Thanks!

@jamezp
Copy link
Member

jamezp commented Oct 13, 2020

@gsmet Are you looking for a revert of the fix then a release of 1.2.2.Final with the revert?

@gsmet
Copy link
Author

gsmet commented Oct 13, 2020

That could be an option :).

I don't exactly know what's going wrong with this patch and why it broke user apps.

@jamezp
Copy link
Member

jamezp commented Oct 13, 2020

Ah okay. Basically the issue is we've got too many abstractions. We've got slf4j -> jboss-logging -> jboss-logmanager. Since we pass the parameters to jboss-logging it passes them to jboss-logmanager. The jboss-logmanager sees the parameters and attempts to format the already formatted message resulting in the failure.

I've made a change to allow https://github.com/jboss-logging/slf4j-jboss-logmanager/ to do that. My suggestion would be to use slf4j-jboss-logmanager if the jboss-logmangaer will always be the log manager.

@gsmet
Copy link
Author

gsmet commented Oct 13, 2020

Could you explain to me the difference between the two artifacts so that I can take an educated decision? Thanks!

@jamezp
Copy link
Member

jamezp commented Oct 13, 2020

@gsmet The difference is that the slf4j-jboss-logging delegates slf4j to jboss-logging. jboss-logging will bind to some log manager as it's a facade itself.

slf4j-jboss-logmanager delegates to jboss-logmanager. So it requires the jboss-logmanager to be used as the log manager.

Does that make sense?

sophokles73 added a commit to eclipse-hono/hono that referenced this issue Dec 3, 2020
The 1.2.1 version of the slf4j-jboss-logging component has issues with
logging statements that contain curly braces as indicated here
jboss-logging/slf4j-jboss-logging#15

We therefore fall back to using the previous version as defined by
Quarus 1.9.2.Final.

Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants