Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ExtLogRecord should be created with no message format when SLF4J formats the message #7

Closed
jamezp opened this issue Oct 12, 2020 · 0 comments · Fixed by #9
Closed

The ExtLogRecord should be created with no message format when SLF4J formats the message #7

jamezp opened this issue Oct 12, 2020 · 0 comments · Fixed by #9

Comments

@jamezp
Copy link
Member

jamezp commented Oct 12, 2020

When the ExtLogRecord log record is created we should use the FormatStyle.NO_FORMAT so there is no attempt to reformat the message if parameters are found in the record. The parameters should also be set on the record for formatters to have access to them.
@jamezp jamezp mentioned this issue Oct 12, 2020
Closed
jamezp added a commit to jamezp/slf4j-jboss-logmanager that referenced this issue Oct 12, 2020
@jamezp
[jboss-logging#7] Pass the format parameters to the log record. Also …
df25510 
…use the NO_FORMAT for the log record as the message should already be formatted by slf4j.
@jamezp jamezp mentioned this issue Oct 12, 2020
Merged
@jamezp jamezp closed this as completed in #9 Oct 12, 2020
jamezp added a commit that referenced this issue Oct 12, 2020
@jamezp
Merge pull request #9 from jamezp/issue7
64f8f14 
[#7] Pass the format parameters to the log record. Also use the NO_FO…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jamezp