[MODULES-270] fixing problem where ClassLoader.definePackage() can th… #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…row IllegalArgumentException on JDK9
dmlloyd
reviewed
Oct 7, 2016
| pkg = super.definePackage(name, specTitle, specVersion, specVendor, implTitle, implVersion, implVendor, sealBase); | ||
| } catch (final IllegalArgumentException iae) { | ||
| pkg = super.getPackage(name); | ||
| } |
There was a problem hiding this comment.
When does this occur? Is this something new in Java 9?
There was a problem hiding this comment.
I noticed that on JDK8 whole method ClassLoader.definePackage() was synchronized.
In JDK9 they're using ConcurrentHashMap.putIfAbsent() instead so it opens a window
for potential concurrent update of the underlying package map. I think this design change is the reason why we can see IllegalArgumentException in some tests.
There was a problem hiding this comment.
Is there any chance an IllegalArgumentException can be thrown without the package being defined in the superclass?
There was a problem hiding this comment.
I think we might want to add an ``if (pkg == null) throw iae;" after that getPackage call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…row IllegalArgumentException on JDK9