Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODULES-378] Module resource loader follows symbolic links (1.8.x) #252

Merged
merged 1 commit into from Feb 10, 2020
Merged

[MODULES-378] Module resource loader follows symbolic links (1.8.x) #252

merged 1 commit into from Feb 10, 2020

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Jan 30, 2020

@ropalka
Copy link
Contributor

ropalka commented Jan 30, 2020

Why is backport to 1.8 branch needed @spyrkob ?

@spyrkob
Copy link
Contributor Author

spyrkob commented Jan 30, 2020

@ropalka we need to fix the issue on EAP 7.2.x stream which is using jboss-modules 1.8.8.

@dmlloyd
Copy link
Contributor

dmlloyd commented Jan 31, 2020

We need to fix the CI issue before we can merge this PR. The CI issue is likely due to a mistake in the test which assumes a certain test environment, and it would need one or two backports of fixes from later branches to correct.

@spyrkob
Copy link
Contributor Author

spyrkob commented Feb 3, 2020

@dmlloyd i think the failures were caused by missing backport of MODULES-395. I opened #253 to fix that

@ropalka ropalka merged commit f6e375b into jboss-modules:1.8 Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@spyrkob @ropalka @dmlloyd