Make ServiceControllerImpl.internalSetMode() change the mode only aft…

…er all validations have been performed.
jboss-msc · Feb 18, 2011 · 88bdada · 88bdada
1 parent 49c87e0
commit 88bdada
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/org/jboss/msc/service/ServiceControllerImpl.java b/src/main/java/org/jboss/msc/service/ServiceControllerImpl.java
@@ -577,7 +577,6 @@ private Runnable internalSetMode(final ServiceController.Mode newMode) {
         assert holdsLock(this);
         Runnable specialTask = null;
         final ServiceController.Mode oldMode = mode;
-        mode = newMode;
         switch (oldMode) {
             case REMOVE: {
                 switch (newMode) {
@@ -698,6 +697,7 @@ private Runnable internalSetMode(final ServiceController.Mode newMode) {
                 break;
             }
         }
+        mode = newMode;
         return specialTask;
     }