[MSC-139] fixing deadlock - moving controller.removeMonitorNoCallback() ... #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() out of synchronized section
| @@ -105,6 +104,9 @@ public void addController(final ServiceController<?> controller) { | |||
| if (controller == null) return; | |||
| final ServiceControllerImpl<?> serviceController = (ServiceControllerImpl<?>) controller; | |||
| synchronized (controllersLock) { | |||
| while (cleanupInProgress) { | |||
| try { controllersLock.wait(); } catch (final InterruptedException ignored) {} | |||
There was a problem hiding this comment.
Interruption cannot simply be ignored. If the thread is interrupted, then at the very least, interruption status should be restored on exit. I usually do something like this:
boolean intr = false;
try {
....
try { xx.wait(); } catch (InterruptedException ignored) { intr = true; }
....
try { xx.wait(); } catch (InterruptedException ignored) { intr = true; }
} finally {
if (intr) Thread.currentThread().interrupt();
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...out of synchronized section