[MSC-204] Fixing invalid shutdown listener notifications #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ee5deb2.
…alled or is removed.
…otification.
Before this fix there were scenarios possible that
shutdown listener have been invoked more than once
and it caused service container to freeze because
container executor have been shutdown prematurely.
Problematic usecase exposing this problem was:
* service container have been shutdown (registering
shutdown listener with all available service controllers)
* problematic service controller entered REMOVED state and
called listener.controllerDied() on shutdown listener
* another concurrent thread later called addListener()
on such problematic already dead controller
(it happened because shutdown was initiated during server boot)
and it resulted in two listeners being created:
- one for LISTENER_ADDED notification
- and one for Transition.REMOVING_to_REMOVED transition
When last transition listener finished execution
and because shutdown listener wasn't cleared
it called shutdown listener.controllerDied() second time
on dead controller which resulted in incorrect notification.
dmlloyd
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.