[CLOUD-449] Expose ARTIFACT_DIR as parameter in s2i templates (EAP) #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @osnipso, because this field is not required and defaults appropriately in the s2i scripts, I think it's better to not specify a value in the templates. If we change the s2i scripts in the future, we'd need to change the templates too. By not setting a default, we will use whatever the script deems appropriate. This comment applies to the other related PRs too. |
|
Ok @rcernich, got it. Just one question before I go ahead and edit the files: you mean not setting a default by leaving it as an empty string ( |
|
looks like we use empty string, "" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSO templates already exposes this parameter, no need to change them.