[CLOUD-2367] Rename existing templates using passthrough TLS termination mode #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcernich
approved these changes
Apr 4, 2018
|
The file name should be the same as the template name |
iankko
force-pushed
the
CLOUD-2367
branch
2 times, most recently
from
3c75ff2
to
9a323c3
Compare
maschmid
suggested changes
Apr 10, 2018
sso/sso72-x509-https.json
Outdated
| "version": "1.4.10", | ||
| "openshift.io/display-name": "Single Sign-On 7.2", | ||
| "openshift.io/display-name": "Red Hat Single Sign-On 7.2 (Ephemeral with re-encrypt TLS)", |
There was a problem hiding this comment.
I'd drop the "with re-encrypt TLS" ... it is the default now, not need to clutter the UI with useless information
sso/sso72-x509-mysql-persistent.json
Outdated
| @@ -6,10 +6,10 @@ | |||
| "iconClass" : "icon-sso", | |||
| "tags" : "sso,keycloak,jboss", | |||
| "version": "1.4.10", | |||
| "openshift.io/display-name": "Single Sign-On 7.2 + MySQL", | |||
| "openshift.io/display-name": "Red Hat Single Sign-On 7.2 + MySQL (Persistent with re-encrypt TLS)", | |||
There was a problem hiding this comment.
I'd drop the "with re-encrypt TLS", same as above
| @@ -6,10 +6,10 @@ | |||
| "iconClass" : "icon-sso", | |||
| "tags" : "sso,keycloak,jboss", | |||
| "version": "1.4.10", | |||
| "openshift.io/display-name": "Single Sign-On 7.2 + PostgreSQL", | |||
| "openshift.io/display-name": "Red Hat Single Sign-On 7.2 + PostgreSQL (Persistent with re-encrypt TLS)", | |||
RH-SSO templates to highlight underlying TLS termination mode used by them (either passthrough, or re-encrypt) Add the 'hidden' tag to: * sso72-mysql-persistent.json and * sso72-postgresql-persistent.json templates, and remove it from: * sso72-x509-https.json template Also: * Replace 'SSO' with 'RH-SSO', and * Add 'displayName' field to MEMORY_LIMIT variable where appropriate. Per request drop "with re-encrypt TLS" from the display-name of the x509 templates Signed-off-by: Jan Lieskovsky <jlieskov@redhat.com>
|
Per request dropped the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Signed-off-by: Jan Lieskovsky jlieskov@redhat.com
Note: This is a replacement for original CLOUD-2367 one. Instead of removing the
HTTP_HOSTNAME/HTTPS_HOSTNAMEvariables, the agreement was to:HTTP_HOSTNAME/ HTTPS_HOSTNAME` variables,passthroughTLS termination mode for routesinstead of the original approach.