Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-2965 move openjdk resources to openjdk container repository #493

Merged
merged 1 commit into from Dec 19, 2018

Conversation

rcernich
Copy link
Contributor

Signed-off-by: rcernich rcernich@redhat.com

Signed-off-by: rcernich <rcernich@redhat.com>
@sspeiche
Copy link
Contributor

sspeiche commented Dec 3, 2018

I looked at https://github.com/jboss-container-images/openjdk but I can't locate the update image-stream definitions, am I missing something?

@rcernich
Copy link
Contributor Author

rcernich commented Dec 4, 2018

They are here but it looks like the default branches have changed. @goldmann, do we need to merge openjdk18-dev into the develop branch?

@goldmann
Copy link

goldmann commented Dec 4, 2018

@rcernich I created the develop branch and made it default a few days ago, because it did not make sense to have a openjdkXY-dev branch where we drop all the versions of this image in the same branch. I notified @jmtd, the new image owner, about this change. The openjdkXY-dev and openjdkXY branches should be dropped and master/develop scheme should be used from now on.

Regarding templates, it looks like this change went into openjdk18-dev branch. I suggest to rebase develop branch with this change and re-push. This could be issue on my side where I did not use proper HEAD of the openjdk18-dev branch to create develop.

@rcernich
Copy link
Contributor Author

rcernich commented Dec 4, 2018

I merged the openjdk18-dev branch into develop. It looks like two commits were missing. The two branches should be in sync now.

@jmtd
Copy link
Contributor

jmtd commented Dec 5, 2018

I've just stumbled across this, after I did sprint 27 builds from the openjdk18-dev branch (for 8 and 11). It looks like the main commit these builds will be missing is 7fedb02bd7ae553ed59a3d180ab5db990e35ea32 which only touches the CTF tests.

@jmtd jmtd merged commit 1e3c9f3 into jboss-openshift:master Dec 19, 2018
@goldmann
Copy link

goldmann commented Jan 2, 2019

@jmtd Please note that the ARQ tests now fail, because these were not updated to point to the new repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants