CLOUD-794 add Connector server config #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcernich
previously approved these changes
Aug 8, 2017
|
The issue seems to be about adding server name, but the commit includes a bunch of extra stuff for configuring ssl keys. Is the ssl configuration for another issue? |
|
prepareEnv() was missing |
rcernich
approved these changes
Aug 10, 2017
maschmid
reviewed
Aug 11, 2017
|
|
||
| function configure_http() { | ||
| if [ -n "$JWS_SERVER_NAME" ]; then | ||
| sed -i "s|redirectPort=\"8443\"|redirectPort=\"8443\" server=\"${JWS_SERVER_NAME}\"|" $JWS_HOME/conf/server.xml |
There was a problem hiding this comment.
I would be much happier if we'd define the JWS_SERVER_NAME operation as "if JWS_SERVER_NAME is specified, it adds the 'server' attribute to all HTTP connectors that didn't already have the attribute set" and then use a proper XML transformation for it... the current behavior generally assumes no customizations have been done on the server.xml...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.