Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-2211 use SYM_ENCRYPT #174

Merged
merged 1 commit into from Dec 14, 2017
Merged

Conversation

bdecoste
Copy link

Thanks for submitting your Pull Request!

Please make sure your PR meets following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull request does not include fixes for other issues than the main ticket
  • Attached commits represent unit of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@redhat.com> - use git commit -s

Copy link
Contributor

@goldmann goldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, I like @slaskawi proposal better (#164). But this approach works too (overriding module). I'm approving/merging this to get this going and finally build the image.

There is already too much talk about how to fix it :)

BTW, the version_compare function is not needed anymore.

configure
}

function version_compare() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

@@ -11,7 +11,7 @@ Feature: Openshift DataGrid tests
| CONTAINER_SECURITY_ROLES | admin=ALL |
| DEFAULT_CACHE_SECURITY_AUTHORIZATION_ENABLED | true |
| DEFAULT_CACHE_SECURITY_AUTHORIZATION_ROLES | admin |
Then container log should contain WFLYSRV0025: Data Grid 7.1.0
Then container log should contain WFLYSRV0025: Data Grid 7.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should refrain from testing exact micro version, if not needed.

@goldmann goldmann merged commit 53d0f0e into jboss-openshift:sprint-12 Dec 14, 2017
@goldmann
Copy link
Contributor

@bdecoste This should be submitted also for master, as part of https://issues.jboss.org/browse/CLOUD-2226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants