[CLOUD-2379] Allow override LAUNCH_DIR #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
reviewed
Mar 14, 2018
ruromero
changed the title
|
I have removed the user tag because for doing a |
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
rcernich
reviewed
Mar 22, 2018
| @@ -4,4 +4,3 @@ version: '1.0' | |||
| description: os-logging script package. | |||
| execute: | |||
| - script: configure.sh | |||
| user: '185' | |||
There was a problem hiding this comment.
@rcernich because this script must be run as root as it executes chown command
There was a problem hiding this comment.
It was doing that before. Is this because LAUNCH_DIR is not owned by jboss user?
There was a problem hiding this comment.
@rcernich I don't know how come it works for other dependencies but chown jboss:root <file> can't work without root permissions UNLESS the ownership was already jboss:root meaning that nothing was changed
rcernich
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for https://issues.jboss.org/browse/RHBA-530
Fixes https://issues.jboss.org/browse/CLOUD-2379
Allows the possibility for non-eap images to decide where to copy the scripts