CLOUD-2869 add support for building jdk 11 based images #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rcernich <rcernich@redhat.com>
jmtd
reviewed
Oct 9, 2018
|
|
||
| # As of rhel 7.6, rh-maven35 pulls in jdk8, so we need to remove them | ||
|
|
||
| if [ -n "$(yum list installed java-1.8.0-openjdk-devel |grep java-1.8.0-openjdk-devel)" ]; then |
There was a problem hiding this comment.
if rpm -q --quiet java-1.8.0-openjdk-devel; then
would be faster and not require a network round-trip (yum list... might cause a metadata refresh)
There was a problem hiding this comment.
Thanks @jmtd, I'll update the check. Yesterday I was thinking about skipping it entirely and just doing something like, yum remove ... || echo "Java 8 not installed".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rcernich rcernich@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets following requirements:
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@redhat.com>- usegit commit -s