CLOUD-3044 move jdk8 removal from jdk11 module to maven module #322
Conversation
rcernich
changed the title
Signed-off-by: rcernich <rcernich@redhat.com>
rcernich
force-pushed
the
maven-jdk8-fix
branch
from
4d6a49d
to
4d84e2e
Compare
|
@jmtd, fyi |
| @@ -13,20 +13,12 @@ pushd ${ARTIFACTS_DIR} | |||
| cp -pr * / | |||
| popd | |||
|
|
|||
| # As of rhel 7.6, rh-maven35 pulls in jdk8, so we need to remove them | |||
There was a problem hiding this comment.
This is a bug in the maven SCL package. Has it been reported in Bugzilla?
There was a problem hiding this comment.
Yes, but it won't be fixed. The dependency for rh-maven35 is on java-devel and jdk 11 provides java-11-devel, so rh-maven35 doesn't see the jdk 11 install and install jdk 8 over top of it. The alternatives --set will ensure that jdk 11 is the default, as it will be installed first (maven module depends on jdk module), even if jdk 8 is installed. The maven module checks to see if jdk 11 is the default and, if it is, removes jdk 8. Note, this whole configuration prevents the installation of multiple jdks (because the jdk modules have the same id).
There was a problem hiding this comment.
Yes, but it won't be fixed. The dependency for rh-maven35 is on java-devel and jdk 11 provides java-11-devel,
I think jdk 11 should be providing both java-devel and java-11-devel.
There was a problem hiding this comment.
I think jdk 11 should be providing both java-devel and java-11-devel.
Sorry for the terseness of my message. To expand: I'm interested in pursuing fixing this in the right place (rpm permissions)) with my new team hat on (or at least learning why it will never be fixed). But in the mean time, working around it in the module as with this PR is the right thing to do (as we did for the JDK7→8 transition period, when the same thing happened). So I will review this PR properly ASAP
Signed-off-by: rcernich rcernich@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets following requirements:
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@redhat.com>- usegit commit -shttp://issues.jboss.org/browse/CLOUD-3044