CLOUD-1817 better logging for multiple jars #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
suggested changes
Jul 26, 2017
os-java-run/added/run-java.sh
Outdated
| @@ -41,10 +46,11 @@ auto_detect_jar_file() { | |||
| ls *.jar | grep -v '^original-' | |||
| exit 0 | |||
| fi | |||
|
|
|||
| echo >&2 "ERROR: Neither \$JAVA_MAIN_CLASS nor \$JAVA_APP_JAR is set and ${nr_jars} found in ${dir} (1 expected)" | |||
There was a problem hiding this comment.
When rendered, the error looks like
ERROR: Neither $JAVA_MAIN_CLASS nor $JAVA_APP_JAR is set and 2 found in /deployments (1 expected)
I think clearly the word "JARs" is missing. Can we change to "${nr_jars} JARs found in ${dir}"?
|
Thanks :-) |
rcernich
reviewed
Jul 26, 2017
| @@ -3,6 +3,11 @@ | |||
| # Fail on a single failed command | |||
| set -eo pipefail | |||
|
|
|||
| if [ "${SCRIPT_DEBUG}" = "true" ] ; then | |||
There was a problem hiding this comment.
We need to make sure this is documented in the image too, if it isn't already (i.e. image.yaml).
rcernich
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.