Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIECLOUD-553] - Adjust permissions on openshift-layer module on cct_… #407

Merged
merged 1 commit into from Jul 20, 2021
Merged

[KIECLOUD-553] - Adjust permissions on openshift-layer module on cct_… #407

merged 1 commit into from Jul 20, 2021

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Jul 13, 2021 •
edited

…module
https://issues.redhat.com/browse/KIECLOUD-553

cherry-picks #407

Signed-off-by: spolti fspolti@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@spolti
[KIECLOUD-553] - Adjust permissions on openshift-layer module on cct_…
096be7f 
…module

Signed-off-by: spolti <fspolti@redhat.com>
@spolti
Copy link
Contributor Author

spolti commented Jul 13, 2021

After reviewed/merged will cherry pick for main branch.

@spolti spolti requested a review from luck3y July 13, 2021 16:13
luck3y
luck3y approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@luck3y luck3y left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @jmtd WDYT?

@luck3y luck3y requested a review from jmtd July 16, 2021 19:00
@jmtd
Copy link
Collaborator

jmtd commented Jul 20, 2021

LGTM, although my images are not using this module anyway. If anything implicitly depends upon the older, wider-scope chmod, this should help to flush it out.

@spolti spolti merged commit 0681213 into jboss-openshift:0.39.x Jul 20, 2021
@spolti spolti deleted the KIECLOUD-553 branch July 20, 2021 20:09
spolti added a commit to spolti/cct_module that referenced this pull request Jul 20, 2021
@spolti
[KIECLOUD-553] - Adjust permissions on openshift-layer module on cct_…
e1ac7b2 
…module (jboss-openshift#407)

Signed-off-by: spolti <fspolti@redhat.com>
@spolti spolti mentioned this pull request Jul 20, 2021
Merged
7 tasks
spolti added a commit that referenced this pull request Jul 20, 2021
@spolti
[KIECLOUD-553] - Adjust permissions on openshift-layer module on cct_…
8c70e71 
…module (#407) (#408)

Signed-off-by: spolti <fspolti@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmtd jmtd jmtd approved these changes

@luck3y luck3y luck3y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spolti @jmtd @luck3y