New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUD-2707] - SqlImporter causes NPE when dbtype is unset #16

Merged

errantepiphany merged 1 commit into jboss-openshift:master from spolti:CLOUD-2707

Sep 24, 2018

Contributor

spolti commented Jul 13, 2018

Signed-off-by: Filippe Spolti fspolti@redhat.com

penehyba commented Jul 16, 2018

I looked into DB_TYPE and have suggestions:
https://github.com/spolti/openshift-kieserver/blob/eb690d65782e590aa56d6fb0841e5b3a0dc5269c/common/src/main/java/org/openshift/kieserver/common/sql/SqlImporter.java#L59
Is it possible DB_TYPE is empty string there.. is it correct to proceed?
https://github.com/spolti/openshift-kieserver/blob/eb690d65782e590aa56d6fb0841e5b3a0dc5269c/common/src/main/java/org/openshift/kieserver/common/sql/SqlImporter.java#L177
Is it possible that DB_TYPE is "postgresql", I suggest
DB_TYPE = DB_TYPE.toUpperCase() right before the switch and have DB_TYPE in upper case since this recognition https://github.com/spolti/openshift-kieserver/blob/eb690d65782e590aa56d6fb0841e5b3a0dc5269c/common/src/main/java/org/openshift/kieserver/common/sql/SqlImporter.java#L214


          [CLOUD-2707] - SqlImporter causes NPE when dbtype is unset

920c16d

Signed-off-by: Filippe Spolti <fspolti@redhat.com>

spolti force-pushed the CLOUD-2707 branch from eb690d6 to 920c16d Compare

August 2, 2018 15:53

errantepiphany self-requested a review

September 24, 2018 16:05

errantepiphany approved these changes

View reviewed changes

errantepiphany merged commit 4284d83 into jboss-openshift:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment