CLOUD-1520: Don't use proxy for all communications at all #31
Conversation
Communications intra-pods don't need to be proxied. In fact they must not. This patch prevents traffic being routed to a proxy in case a java property like "http.proxyHost" is set in the environment. As a side effect of this change, clustering will not be affected by env variables like "https_proxy".
|
I have tested it "by hand" and it worked as expected. I'm going to write a test in ce-testsuite for it as well. |
|
It's done: jboss-openshift/ce-testsuite#170 |
|
Hey @knrc, do you mind giving this a quick review. It looks fine to me, but I'm wondering if we should make this configurable, with the default being no-proxy. Also, on another jira, I mentioned that a better solution would be to tell folks to configure no_proxy when they configure their proxy settings for the cluster. When doing so, they should add svc. to the no_proxy list, which would circumvent all of these problems (thought of after we'd addressed this in all the probes). Short: I'm fine with this as-is, but would like confirmation. |
|
@rcernich I think it is the right decision to force all inter-pod communication over NO_PROXY handlers, I can't think of any reason why using a proxy for this communication would make sense. |
Communications intra-pods don't need to be proxied. In fact
they must not. This patch prevents traffic being routed to
a proxy in case a java property like "http.proxyHost" is set
in the environment.
As a side effect of this change, clustering will not be
affected by env variables like "https_proxy".