Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REM3-259] (3.3) Authentication via remoting fail for larger requests i.e. long password #111

Merged
merged 1 commit into from Jun 27, 2017
Merged

[REM3-259] (3.3) Authentication via remoting fail for larger requests i.e. long password #111

merged 1 commit into from Jun 27, 2017

Conversation

rnetuka
Copy link

@rnetuka rnetuka commented May 9, 2017 •
edited

@rnetuka rnetuka force-pushed the large-buffer-for-password-33 branch from adedb1f to 3b036fc Compare May 9, 2017 12:58
@rnetuka rnetuka changed the title [REM3-259] Authentication via remoting fail for larger requests i.e. long password [REM3-259] (3.3) Authentication via remoting fail for larger requests i.e. long password May 16, 2017
dmlloyd
dmlloyd requested changes May 19, 2017
View reviewed changes
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR causes the test suite to hang every time for me in ConnectionTestCase.

@rnetuka rnetuka force-pushed the large-buffer-for-password-33 branch from 3b036fc to 58a5f9a Compare May 23, 2017 08:05
@rnetuka
Copy link
Author

rnetuka commented May 23, 2017

There was a NullPointerException emerging when running ConnectionTestCase. I've added null check. The test should be ok now.
(force pushed the changes to my repo - please retry again)

@dmlloyd
Copy link
Member

dmlloyd commented May 23, 2017 

Tests in error: 
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...
  RemoteSslChannelTest.testStart:92 » IO JBREM000202: Abrupt close on Remoting c...

@rnetuka rnetuka force-pushed the large-buffer-for-password-33 branch from 58a5f9a to e7a17c3 Compare May 24, 2017 13:39
@rnetuka
Copy link
Author

rnetuka commented May 24, 2017

Fixed. The readMessageLength() method now returns 0 when length cannot be read (code fragment taken from FramedMessageChannel).

@dmlloyd dmlloyd merged commit fca0c05 into jboss-remoting:3.3 Jun 27, 2017
dmlloyd added a commit that referenced this pull request Jun 27, 2017
@dmlloyd
Merge pull request #111 from rnetuka/large-buffer-for-password-33
d3cdd62 
[REM3-259] (3.3) Authentication via remoting fail for larger requests i.e. long password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlloyd dmlloyd dmlloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnetuka @dmlloyd