PostMissingPR - No PR link required when the patch is hosted in other SCM

[elguardian]

This happens when the PR is attached as a patch to the BZ because the SCM is the SVN (jboss-web project)

[rpelisse]

Hi Enrique,

Do you mean it should be a check somehow or are you refering to any issue with an existing check ?

[elguardian]

they should be removed. Right now there bugclerk rise an error and adds a comment to the BZ when the bz is correct. POST + patch attached.

[rpelisse]

OK, first, as you did not answer to that, I'm going to assume you are talking about the check called 'PostMissingPR'.

Right now there bugclerk rise an error and adds a comment to the BZ when the bz is correct

OK, that what we called a False +, meaning that a check is reporting an issue where there is not. There are a bit annoying, but in this case, they are not so common. I think up until know I got less 5 occurences of such False + for this check.

I think it's not a high price to pay in exchange for all the time the check is actually correct. The check actually catch me forgetting to add the PR to a BZ probably as much.

Also, given the fact that there is a workaround (you can add a comment for BugClerk to NOT report this issue, if you know your BZ will look errrounous), I honestly it's fair.