Conversation
*/ | ||
@RunWith(Arquillian.class) | ||
@RunAsClient | ||
@EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap7/management/src/main/java","modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java","modules/testcases/jdkAll/Eap71x/management/src/main/java","modules/testcases/jdkAll/Wildfly/management/src/main/java"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"modules/testcases/jdkAll/Eap7/management/src/main/java" should be removed, as it is used for the current released version of 7.1.0
Since the PR is not merged yet and the new component version in not updated in the servers, we could either disable the @ EapAdditionalTestsuite annotation by e.g. commenting it to //@ AdditionalTestsuite or we could add estimates of the versions of the servers that the fix will be included (e.g. @ EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java#7.1.4","modules/testcases/jdkAll/Eap71x/management/src/main/java#7.1.4","modules/testcases/jdkAll/Wildfly/management/src/main/java#14.0.0"}))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for review. Annotation modified according to your comment.
@@ -53,7 +53,7 @@ | |||
*/ | |||
@RunWith(Arquillian.class) | |||
@RunAsClient | |||
@EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap7/management/src/main/java","modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java","modules/testcases/jdkAll/Eap71x/management/src/main/java","modules/testcases/jdkAll/Wildfly/management/src/main/java"}) | |||
@EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java#7.1.4","modules/testcases/jdkAll/Eap71x/management/src/main/java#7.1.4","modules/testcases/jdkAll/Wildfly/management/src/main/java#14.0.0"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use also the comment approach for now, as we are not sure when this will be included (after all it is just an estimation)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, done
*/ | ||
@RunWith(Arquillian.class) | ||
@RunAsClient | ||
//@EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java#7.1.4","modules/testcases/jdkAll/Eap71x/management/src/main/java#7.1.4","modules/testcases/jdkAll/Wildfly/management/src/main/java#14.0.0"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change //@ EapAdditionalTestsuite to //@ AdditionalTestsuite ? @ EapAdditionalTestsuite distributes the code also when it is commented. This is done in order to be used with any programming language, configurations, and other .txt, .xml, etc resources.
I am merging it. Thank you. We just need to activate it when the fix is merged. |
Thank you. |
No description provided.