Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

testcase for JBJCA-1375 JBEAP-14635 #34

Merged
merged 4 commits into from May 23, 2018
Merged

Conversation

jirka007
Copy link
Contributor

No description provided.

@jirka007 jirka007 requested a review from panossot as a code owner May 21, 2018 12:31
*/
@RunWith(Arquillian.class)
@RunAsClient
@EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap7/management/src/main/java","modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java","modules/testcases/jdkAll/Eap71x/management/src/main/java","modules/testcases/jdkAll/Wildfly/management/src/main/java"})
Copy link
Collaborator

@panossot panossot May 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"modules/testcases/jdkAll/Eap7/management/src/main/java" should be removed, as it is used for the current released version of 7.1.0
Since the PR is not merged yet and the new component version in not updated in the servers, we could either disable the @ EapAdditionalTestsuite annotation by e.g. commenting it to //@ AdditionalTestsuite or we could add estimates of the versions of the servers that the fix will be included (e.g. @ EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java#7.1.4","modules/testcases/jdkAll/Eap71x/management/src/main/java#7.1.4","modules/testcases/jdkAll/Wildfly/management/src/main/java#14.0.0"}))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review. Annotation modified according to your comment.

@@ -53,7 +53,7 @@
*/
@RunWith(Arquillian.class)
@RunAsClient
@EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap7/management/src/main/java","modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java","modules/testcases/jdkAll/Eap71x/management/src/main/java","modules/testcases/jdkAll/Wildfly/management/src/main/java"})
@EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java#7.1.4","modules/testcases/jdkAll/Eap71x/management/src/main/java#7.1.4","modules/testcases/jdkAll/Wildfly/management/src/main/java#14.0.0"})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use also the comment approach for now, as we are not sure when this will be included (after all it is just an estimation)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, done

*/
@RunWith(Arquillian.class)
@RunAsClient
//@EapAdditionalTestsuite({"modules/testcases/jdkAll/Eap71x-Proposed/management/src/main/java#7.1.4","modules/testcases/jdkAll/Eap71x/management/src/main/java#7.1.4","modules/testcases/jdkAll/Wildfly/management/src/main/java#14.0.0"})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change //@ EapAdditionalTestsuite to //@ AdditionalTestsuite ? @ EapAdditionalTestsuite distributes the code also when it is commented. This is done in order to be used with any programming language, configurations, and other .txt, .xml, etc resources.

@panossot
Copy link
Collaborator

I am merging it.
I have also tested it with the fix and it fixes the issue :
Running org.jboss.additional.testsuite.jdkall.present.core.jca.DatasourcesActiveCountTestCase
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.198 sec - in org.jboss.additional.testsuite.jdkall.present.core.jca.DatasourcesActiveCountTestCase

Thank you. We just need to activate it when the fix is merged.

@panossot panossot merged commit dd11a62 into jboss-set:master May 23, 2018
@jirka007
Copy link
Contributor Author

Thank you.
When the fix will be merged I will send PR for activating this test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants