New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split SYSTEMD_ENABLED to PRIVILEGED_ENABLED and CGROUP_MOUNT_ENABLED #14
Conversation
BTW, from https://docs.podman.io/en/latest/markdown/podman-run.1.html#systemd-true-false-always, the |
@rpelisse would you please review ? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaol a few more enhancement, but otherwise it's look good.
run.sh
Outdated
@@ -83,7 +90,7 @@ readonly CONTAINER_COMMAND=${CONTAINER_COMMAND:-"${WORKSPACE}/hera/wait.sh"} | |||
run_ssh "podman run \ | |||
--name "${CONTAINER_TO_RUN_NAME}" $(container_user_if_enabled) \ | |||
--add-host=${CONTAINER_SERVER_HOSTNAME}:${CONTAINER_SERVER_IP} \ | |||
--rm $(add_parent_volume_if_provided) $(systemd_if_enabled) \ | |||
--rm $(add_parent_volume_if_provided) $(privileged_if_enabled) $(cgroup_mount_if_enabled) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move this to a newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to a newline will lead to double \
in case they are not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spyrkob LGTM! any comment?
LGTM |
This relates to issue: https://issues.redhat.com/browse/SET-422, but if anyone think this deserves a new issue, I can create one for it.