Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SET-570 Automate updating CCI worker VMs in Gitlab. #220

Merged
merged 1 commit into from
Jun 6, 2023
Merged

SET-570 Automate updating CCI worker VMs in Gitlab. #220

merged 1 commit into from
Jun 6, 2023

Conversation

RanabirChakraborty
Copy link
Contributor

@RanabirChakraborty RanabirChakraborty commented Apr 26, 2023

Issue: https://issues.redhat.com/browse/SET-570

it can do the following ->

  • Clone your forked csb-jenkins-definition from gitlab.
  • rebase it with changes with the upstream repo.
  • Updated the newly formed image name
  • create the PR

Zeus vars PR: https://gitlab.cee.redhat.com/jboss-set/zeus-vars/-/merge_requests/80

@RanabirChakraborty
Copy link
Contributor Author

RanabirChakraborty commented Apr 26, 2023

@spyrkob I check thoroughly but there is no way to create PR from a different branch other than the master branch using the command module. I even checked the git module but there is no way to send a PR. In my mind there are three solutions -

  1. If we can get the admin access (or the credentials) then we can directly send the push request to csb-jenkins-definition and at the same time can reload Jenkins with the new changes. In this way, we can achieve full automation.
  2. We can maintain a duplicate branch in csb-jenkins-definition which will be an exact copy of the master branch and can send the PR using that and we can merge it manually. [ Issue - eventually too many branches will form in the main repo]
  3. Clone the personal fork repo and using that send the PR and we can merge it manually. [ Issue - Fork repo has to be there beforehand]

@spyrkob
Copy link
Collaborator

spyrkob commented Apr 28, 2023

@RanabirChakraborty, thanks for the summary. I think option 3 sounds best - it should be a safe to assume a user has a fork if they're doing changes. And it allows for users without write permissions to main repo to still prepare the update

@spyrkob
Copy link
Collaborator

spyrkob commented May 15, 2023

@RanabirChakraborty do you know if this molecule failure is related to the PR or something wrong with the env?

@RanabirChakraborty
Copy link
Contributor Author

RanabirChakraborty commented May 16, 2023

There is a recent change in the GitHub Ubuntu image, that's why molecule 5.0 is failing. Here is the listed issue - ansible/molecule#3883

The previous molecule[podman] will not work now. As a fix, we need to move from molecule[podman] to molecule-plugins[podman]. Logged a new SET issue here. I'm working on it.

Copy link
Collaborator

@spyrkob spyrkob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpelisse rpelisse merged commit 36d3cb9 into jboss-set:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants