Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBWS-4097] JAXB doesn't (un)marshall property with @XmlElementRef #18

Closed
wants to merge 1 commit into from

Conversation

rnetuka
Copy link

@rnetuka rnetuka commented Apr 11, 2018

JIRA: https://issues.jboss.org/browse/JBWS-4097

Current implementation seems to ignore properties with @XmlElementRef annotation.

This is serious since JAX-WS generators do use this annotation in output code.

@scottmarlow
Copy link

Is this change already in https://github.com/apache/cxf?

Copy link

@asoldano asoldano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnetuka the changes look good. This said, as Scott is implying, we need the same fix pushed upstream first, basically a JIRA at https://issues.apache.org/jira/browse/CXF and a PR mentioning it at https://github.com/apache/cxf . Can you please create them and let me know, so that I approve/merge the PR upstream first? Thanks

@rnetuka
Copy link
Author

rnetuka commented Apr 12, 2018

@asoldano @scottmarlow
Upstream JIRA:
https://issues.apache.org/jira/browse/CXF-7707

Upstream PR:
apache#404
(btw. check the cool PR number :) )

@asoldano
Copy link

asoldano commented May 8, 2018

@rnetuka OK, great, the PR upstream has been merged, thanks. Now, I just noticed that this PR is against master here, which is of no use. So, if we need the fix for EAP 7.1.x, we should start by opening up a corresponding PR against cxf-3.1.x-fixes . Also please note the last comment at https://issues.apache.org/jira/browse/CXF-7707 , if it's not too much effort, it might be worth adding a testcase in cxf sources.

@asoldano asoldano closed this May 8, 2018
@asoldano
Copy link

asoldano commented May 8, 2018

We might need yet another PR on the repo here, against one of our branches, if the fix is needed for EAP 7.0.x or previous. Let's see...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants