Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CXF 7711] compiler instance to java to ws #19

Closed
wants to merge 3,050 commits into from
Closed

[CXF 7711] compiler instance to java to ws #19

wants to merge 3,050 commits into from

Conversation

rsearls
Copy link

@rsearls rsearls commented Apr 17, 2018

Enables custom compiler to be used by JavaToWS

coheigea and others added 30 commits January 5, 2018 17:31
Use Messages.properties and change message to better indicate that an
error occurred during error handling, preventing further action.
CXF-7604 Refine error message during error handling
Most CXF modules depend on annotation 1.3, but MP Rest Client 1.0 is
part of MP 1.3 which prereqs EE7 (annotation 1.2).  This is required so
that MP Rest Client 1.0 will operate in an EE7 environment.
JAX-RS 2.1 defaults the no-longer-used getSize method to -1, but in
order to run an JAX-RS 2.0, we must have an implementation of this
method.
We should not need to call handleMapper for the ResponseExceptionMappers
 - they already require the parameterized type to be a subclass of
Throwable. And the handleMapper method checks whether the Throwable
class can be assigned to the type in the user's REM - which it never
will be (unless they define ResponseExceptionMapper<Throwable>).

This also adds unit tests ensuring that the REM is executed.
[CXF-7597] Fix suspicious class loader findResource calls
…egration implementation. Adding support for customizations (dynamic base path)
ffang and others added 22 commits April 10, 2018 15:45
… when generating ws client jars with jaxws bindings
fix wrong log warning "Unable to recognize the addressing policy"
[CXF-7707] JAXB doesn't (un)marshall property with @XmlElementRef
…een broadcasting and closing the broadcaster)
@scottmarlow
Copy link

Looks like there are too many git commits included in this pull request, maybe the pull request was created against a different branch than intended?

@rsearls
Copy link
Author

rsearls commented Apr 17, 2018

I see that it is but I don't understand how that can be. I did a rebase from upstream master to origin master before I created the branch minutes later. And I committed and submitted the code with in minutes after that.

@dmlloyd
Copy link
Member

dmlloyd commented Apr 17, 2018

Time is not a factor, only the commit graph matters. Rebasing will not always correctly identify the list of commits, particularly if the commits you are interested in have a divergent ancestry from the place you're trying to bring them to.

For simplicity's sake, you may want to do a hard reset to the base branch, and then cherry-pick each commit you want to bring in, in order.

@rsearls
Copy link
Author

rsearls commented Apr 17, 2018

My intent is to sync my master to the upstream master and commit my changes against that. I'm no power user of git. I don't understand why rebasing to upstream master and creating my branch and commit as described above did not do that. Why all these other commits? I don't see that my changes are affected by any of those previous commits.

@rsearls
Copy link
Author

rsearls commented Apr 17, 2018

I'm closing this and trying again.

@rsearls rsearls closed this Apr 17, 2018
@asoldano
Copy link

asoldano commented Apr 18, 2018

I'm not checking all the commits in the PR here, but please note that the last commit on master here is ~3yrs old. The upstream apache cxf master has clearly evolved in the mean time so it's likely hundreds of commits are missing here to synch with upstream master.
This said, if we want to synch now, that should be in an independent PR.
The PR for the fix here should only include the relevant commit.
Finally, for the jira that leads to needing this fix (WFLY-10238), we have two options: either we wait for the first upstream release of cxf that includes the fix and upgrade WildFly to it, or we branch off the cxf version that's currently in WildFly (3.2.4 afair), apply the relevant commit on that branch and release a custom 3.2.4.jbossorg version from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet