Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBEE-215] Jakarta Concurrency API Manifest setup #1

Merged
merged 1 commit into from Aug 27, 2019

Conversation

emmartins
Copy link
Collaborator

@emmartins
Copy link
Collaborator Author

@scottmarlow I'm a bit unsure wrt the values to the following headers that we had:

Specification-Title: JSR-000236 Concurrency Utilities API
Specification-Vendor: Oracle

So decided to skip these for now...

@emmartins emmartins mentioned this pull request Aug 22, 2019
@scottmarlow
Copy link

@emmartins
I built the upstream eclipse project and see the generated target/classes/META-INF/MANIFEST.MF is:

Manifest-Version: 1.0
Bnd-LastModified: 1566476771719
Build-Jdk: 1.8.0_181
Built-By: smarlow
Bundle-Description: Jakarta Concurrency
Bundle-DocURL: http://www.oracle.com/
Bundle-License: http://www.eclipse.org/legal/epl-2.0, https://www.gnu.or
 g/software/classpath/license.html
Bundle-ManifestVersion: 2
Bundle-Name: jakarta.enterprise.concurrent-api
Bundle-SymbolicName: jakarta.enterprise.concurrent-api
Bundle-Vendor: Oracle Corporation
Bundle-Version: 1.1.2
Created-By: Apache Maven Bundle Plugin
Export-Package: javax.enterprise.concurrent;version="1.1.2"
Extension-Name: javax.enterprise.concurrent
Implementation-Version: 1.1.2
Specification-Version: 1.1
Tool: Bnd-1.50.0

I also did the same of the current jboss-jakarta-concurrency-api project (without any pullrequests merged):

Manifest-Version: 1.0
Bnd-LastModified: 1566476550932
Build-Jdk: 1.8.0_181
Built-By: smarlow
Bundle-Description: Jakarta Concurrency
Bundle-DocURL: http://www.jboss.org
Bundle-License: http://www.eclipse.org/legal/epl-2.0, https://www.gnu.or
 g/software/classpath/license.html
Bundle-ManifestVersion: 2
Bundle-Name: jakarta.enterprise.concurrent-api
Bundle-SymbolicName: 
Bundle-Vendor: JBoss by Red Hat
Bundle-Version: 0
Created-By: Apache Maven Bundle Plugin
Export-Package: javax.enterprise.concurrent;version="${spec.bundle.versi
 on}"
Implementation-Title: jakarta.enterprise.concurrent-api
Implementation-URL: https://github.com/jboss/jboss-jakarta-concurrency-a
 pi
Implementation-Vendor: JBoss by Red Hat
Implementation-Vendor-Id: org.jboss.spec.javax.enterprise.concurrent
Implementation-Version: 2.0.0.CR1-SNAPSHOT
Java-Vendor: Oracle Corporation
Java-Version: 1.8.0_181
Os-Arch: amd64
Os-Name: Linux
Os-Version: 5.2.7-200.fc30.x86_64
Scm-Connection: scm:git:ssh://git@github.com/jboss/jboss-jakarta-concurr
 ency-api.git
Scm-Revision: 08/22/2019 08:22 AM
Scm-Url: https://github.com/jboss/jboss-jakarta-concurrency-api
Specification-Title: jakarta.enterprise.concurrent-api
Specification-Vendor: JBoss by Red Hat
Specification-Version: 2.0.0.CR1-SNAPSHOT
Tool: Bnd-1.50.0

What are you seeing with your changes for contents of target/classes/META-INF/MANIFEST.MF file?

@emmartins
Copy link
Collaborator Author

emmartins commented Aug 22, 2019

@scottmarlow this is what I get with this PR:

Manifest-Version: 1.0
Automatic-Module-Name: beta.jboss.concurrency.api_1_0
Bnd-LastModified: 1566481648340
Build-Jdk: 1.8.0_222
Built-By: emmartins
Bundle-Description: Jakarta Concurrency
Bundle-DocURL: http://www.jboss.org
Bundle-License: http://www.eclipse.org/legal/epl-2.0, https://www.gnu.or
 g/software/classpath/license.html
Bundle-ManifestVersion: 2
Bundle-Name: jakarta.enterprise.concurrent-api
Bundle-SymbolicName: org.jboss.spec.javax.enterprise.concurrent.jboss-co
 ncurrency-api_1.0_spec
Bundle-Vendor: JBoss by Red Hat
Bundle-Version: 2.0.0.CR1-SNAPSHOT
Created-By: Apache Maven Bundle Plugin
Export-Package: javax.enterprise.concurrent;version="1.0"
Implementation-Title: jakarta.enterprise.concurrent-api
Implementation-URL: https://github.com/jboss/jboss-jakarta-concurrency-a
 pi
Implementation-Vendor: JBoss by Red Hat
Implementation-Vendor-Id: org.jboss.spec.javax.enterprise.concurrent
Implementation-Version: 2.0.0.CR1-SNAPSHOT
Java-Vendor: AdoptOpenJDK
Java-Version: 1.8.0_222
Os-Arch: x86_64
Os-Name: Mac OS X
Os-Version: 10.14.6
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
Scm-Connection: scm:git:ssh://git@github.com/jboss/jboss-jakarta-concurr
 ency-api.git
Scm-Revision: 08/22/2019 02:47 PM
Scm-Url: https://github.com/jboss/jboss-jakarta-concurrency-api
Specification-Version: 1.0
Tool: Bnd-3.5.0.201709291849

@emmartins emmartins merged commit 8f0cc29 into jboss:master Aug 27, 2019
@emmartins emmartins deleted the JBEE-215 branch August 27, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants