Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-16771] Remove bcel from jboss/xalan-j binaries (Fix CVE-2022-34… #7

Merged
merged 2 commits into from Aug 23, 2022

Conversation

bstansberry
Copy link

@bstansberry bstansberry commented Aug 10, 2022

@bstansberry
Copy link
Author

Put a hold on this; I got test failures with it.

@bstansberry bstansberry force-pushed the WFLY-16771 branch 4 times, most recently from 0501c66 to 609dbc6 Compare August 10, 2022 22:25
For example:

export CLASSPATH=~/.m2/repository/org/jboss/spec/javax/ejb/jboss-ejb-api_3.2_spec/2.0.0.Final/jboss-ejb-api_3.2_spec-2.0.0.Final.jar: \
~/.m2/repository/org/jboss/spec/javax/servlet/jboss-servlet-api_4.0_spec/2.0.0.Final/jboss-servlet-api_4.0_spec-2.0.0.Final.jar

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happen to have javax.servlet api in:
~/.m2/repository/javax/servlet/javax.servlet-api/3.1.0/javax.servlet-api-3.1.0.jar
~/.m2/repository/javax/servlet/javax.servlet-api/4.0.1/javax.servlet-api-4.0.1.jar

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everyone will have different jars I'm sure, especially if they occasionally delete their maven repo. No change needed really.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

I went with the spec fork GAVs as the example just because it's more likely a typical WildFly dev would have those vs having the javax.* Eclipse artifacts.

@scottmarlow
Copy link

Put a hold on this; I got test failures with it.

Thanks, will wait.

@@ -1 +1 @@
org.apache.xalan.xsltc.trax.TransformerFactoryImpl
org.apache.xalan.processor.TransformerFactoryImpl
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this change, which I believe means a change in the default TransformerFactory for WF users. (I could be wrong.) The new value here is the one EAP has been using for many years. The existing value uses BCEL, which is not present in the xalan-j.jar that EAP ships.

@bstansberry
Copy link
Author

@scottmarlow The test issues I mentioned previously are resolved.

@bstansberry bstansberry merged commit 707ad6d into jboss:jboss_2_7_1 Aug 23, 2022
@bstansberry bstansberry deleted the WFLY-16771 branch August 23, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants