Add onFailure() for enable deployment to hide modal dialog

jbossas · Dec 20, 2012 · 4f2a9c0 · 4f2a9c0
1 parent 60e32e0
commit 4f2a9c0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/.../java/org/jboss/as/console/client/domain/groups/deployment/DomainDeploymentPresenter.java b/.../java/org/jboss/as/console/client/domain/groups/deployment/DomainDeploymentPresenter.java
@@ -128,6 +128,7 @@ public void onSuccess(final ContentRepository result)
     @Override
     public void enableDisableDeployment(final DeploymentRecord record)
     {
+        // TODO Distinguish between enable and disable and user proper messages
         final PopupPanel loading = Feedback.loading(
                 Console.CONSTANTS.common_label_plaseWait(),
                 Console.CONSTANTS.common_label_requestProcessed(),
@@ -143,12 +144,17 @@ public void onCancel()
         deploymentStore.enableDisableDeployment(record, new SimpleCallback<DMRResponse>()
         {
             @Override
-            public void onSuccess(DMRResponse response)
+            public void onFailure(final Throwable caught)
             {
                 loading.hide();
+                Console.error(Console.MESSAGES.modificationFailed("Deployment " + record.getRuntimeName()), caught.getMessage());
+            }
 
+            @Override
+            public void onSuccess(DMRResponse response)
+            {
+                loading.hide();
                 ModelNode result = response.get();
-
                 if (result.isFailure())
                 {
                     Console.error(Console.MESSAGES.modificationFailed("Deployment " + record.getRuntimeName()),
@@ -161,7 +167,6 @@ public void onSuccess(DMRResponse response)
                 refreshDeployments();
             }
         });
-
     }
 
     @Override

diff --git a/...java/org/jboss/as/console/client/standalone/deployment/StandaloneDeploymentPresenter.java b/...java/org/jboss/as/console/client/standalone/deployment/StandaloneDeploymentPresenter.java
@@ -154,6 +154,7 @@ public void onFailure(Throwable t)
     @Override
     public void enableDisableDeployment(final DeploymentRecord record)
     {
+        // TODO Distinguish between enable and disable and user proper messages
         final PopupPanel loading = Feedback.loading(
                 Console.CONSTANTS.common_label_plaseWait(),
                 Console.CONSTANTS.common_label_requestProcessed(),
@@ -168,6 +169,13 @@ public void onCancel()
 
         deploymentStore.enableDisableDeployment(record, new SimpleCallback<DMRResponse>()
         {
+            @Override
+            public void onFailure(final Throwable caught)
+            {
+                loading.hide();
+                Console.error(Console.MESSAGES.modificationFailed("Deployment " + record.getRuntimeName()), caught.getMessage());
+            }
+
             @Override
             public void onSuccess(DMRResponse response)
             {