Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Helm chart name for EAP 7.4 is not displayed correctly in OpenShift Dev Console #39

Closed
jmesnil opened this issue Feb 14, 2023 · 0 comments · Fixed by #40
Closed

The Helm chart name for EAP 7.4 is not displayed correctly in OpenShift Dev Console #39

jmesnil opened this issue Feb 14, 2023 · 0 comments · Fixed by #40
Labels
bug Something isn't working
Projects
EAP Charts
Milestone
EAP 7.4 1.1.1

Comments

@jmesnil
Copy link
Contributor

jmesnil commented Feb 14, 2023

The Helm Chart for EAP 7.4 is displayed with the name Eap74 in the OpenShift Dev Console which is not following our naming convention.

Instead, it should be displayed as JBoss EAP 7.4 using the charts.openshift.io/name annotation in its Chart.yaml:

annotations:
  charts.openshift.io/name: JBoss EAP 7.4
  charts.openshift.io/supportURL: https://access.redhat.com/support

(I've added the support link which is another annotation we can provide to the OpenShift Dev Console)
@jmesnil jmesnil added the bug Something isn't working label Feb 14, 2023
@jmesnil jmesnil added this to the EAP 7.4 1.1.1 milestone Feb 14, 2023
@jmesnil jmesnil added this to To do in EAP Charts via automation Feb 14, 2023
jmesnil added a commit to jmesnil/eap-charts that referenced this issue Feb 14, 2023
@jmesnil
[jbossas#39] fix name in OpenShift Dev Console
3e7e382 
added charts.openshift.io/name annotation to display the
Helm Chart as 'JBoss EAP 7.4'

this fixes jbossas#39

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil added a commit to jmesnil/eap-charts that referenced this issue Feb 14, 2023
@jmesnil
[jbossas#39] fix name in OpenShift Dev Console
b75fde7 
added charts.openshift.io/name annotation to display the
Helm Chart as 'JBoss EAP 7.4'

this fixes jbossas#39

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil added a commit to jmesnil/eap-charts that referenced this issue Feb 22, 2023
@jmesnil
[jbossas#41] Provide a default Jakarta EE application to build
d1a4b7f 
* Use https://github.com/jboss-eap-up-and-running/eap7-getting-started
  as the default Jakarta EE application
* bump wildfly-common version to 1.3.1
* bump eap74 version to 1.1.1
* add missing Chart metadata (icon, maintainers, display name)

This fixes jbossas#41
This fixes jbossas#39

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil added a commit that referenced this issue Feb 22, 2023
@jmesnil
Merge pull request #40 from jmesnil/39_eap74_description
aeaadb4 
[#39] fix name in OpenShift Dev Console
@jmesnil jmesnil linked a pull request Feb 22, 2023 that will close this issue
[#39] fix name in OpenShift Dev Console #40
Merged
@jmesnil jmesnil closed this as completed Feb 22, 2023
EAP Charts automation moved this from To do to Done Feb 22, 2023
jmesnil added a commit to jmesnil/eap-charts that referenced this issue Feb 22, 2023
@jmesnil
[jbossas#39] fix name in OpenShift Dev Console
0891846 
added charts.openshift.io/name annotation to display the
Helm Chart as 'JBoss EAP 7.4'

this fixes jbossas#39

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
EAP Charts
Done
Milestone
EAP 7.4 1.1.1
Development

Successfully merging a pull request may close this issue.

[#39] fix name in OpenShift Dev Console jmesnil/eap-charts
1 participant
@jmesnil