AS7-3712: be more informative when the bound-port is undefined

jbossas · Feb 10, 2012 · d7dbc2c · d7dbc2c
1 parent a4db9bc
commit d7dbc2c
Showing 1 changed file with 19 additions and 14 deletions.
diff --git a/arquillian/common/src/main/java/org/jboss/as/arquillian/container/ManagementClient.java b/arquillian/common/src/main/java/org/jboss/as/arquillian/container/ManagementClient.java
@@ -16,18 +16,6 @@
  */
 package org.jboss.as.arquillian.container;
 
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.DEPLOYMENT;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.FAILURE_DESCRIPTION;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP_ADDR;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OUTCOME;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.READ_ATTRIBUTE_OPERATION;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.READ_RESOURCE_OPERATION;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.RECURSIVE;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.RESULT;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.SUBSYSTEM;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.SUCCESS;
-
 import java.io.IOException;
 import java.net.URI;
 import java.util.HashMap;
@@ -47,9 +35,20 @@
 import org.jboss.as.controller.PathAddress;
 import org.jboss.as.controller.client.ModelControllerClient;
 import org.jboss.as.controller.operations.common.Util;
-import org.jboss.as.protocol.mgmt.ProtocolUtils;
 import org.jboss.dmr.ModelNode;
 
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.DEPLOYMENT;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.FAILURE_DESCRIPTION;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP_ADDR;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OUTCOME;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.READ_ATTRIBUTE_OPERATION;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.READ_RESOURCE_OPERATION;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.RECURSIVE;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.RESULT;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.SUBSYSTEM;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.SUCCESS;
+
 /**
  * A helper class to join management related operations, like extract sub system ip/port (web/jmx)
  * and deployment introspection.
@@ -183,6 +182,12 @@ private void readRootNode() throws Exception {
         rootNode = readResource(new ModelNode());
     }
 
+    private static ModelNode defined(final ModelNode node, final String message) {
+        if (!node.isDefined())
+            throw new IllegalStateException(message);
+        return node;
+    }
+
     private URI getBinding(final String socketBinding) {
         try {
             //TODO: resolve socket binding group correctly
@@ -200,7 +205,7 @@ private URI getBinding(final String socketBinding) {
             portOp.get(OP_ADDR).get("socket-binding").set(socketBinding);
             portOp.get(OP).set(READ_ATTRIBUTE_OPERATION);
             portOp.get(NAME).set("bound-port");
-            final int port = executeForResult(portOp).asInt();
+            final int port = defined(executeForResult(portOp), socketBindingGroupName + " -> " + socketBinding + " -> bound-port is undefined").asInt();
 
             return URI.create(socketBinding + "://" + NetworkUtils.formatPossibleIpv6Address(ip) + ":" + port);
         } catch (Exception e) {