[EJBCLIENT-162] EJB client unnecessary mark a channel/connection as broken if can't read a message #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roken if can't read a message Do not exclude the node when failed to send invocation
gaol
commented
May 10, 2017
| Logs.MAIN.debugf(rsfe, "Retrying invocation %s which failed on node: %s due to:", clientInvocationContext, failedNodeName); | ||
| // exclude this failed node, during the retry | ||
| clientInvocationContext.markNodeAsExcluded(failedNodeName); |
There was a problem hiding this comment.
What customer complained was that "Further EJB invocations are rejected with EJBCLIENT0025". Don't exclude the node in the retry process will prevent that.
|
@dmlloyd Could you please take a look at this PR? Thank you very much! |
|
I think we need an upstream (2.x, 3.x) PR for this as well. |
This was referenced Jul 28, 2017
|
Thank you to taking care of this PR.
|
This was referenced Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.jboss.org/browse/EJBCLIENT-162
EAP 7.0 Jira: https://issues.jboss.org/browse/JBEAP-5411
EAP 7.1 Jira: https://issues.jboss.org/browse/JBEAP-5413 - Verified
This issue does not happen anymore in EAP 7.1 after updating jboss-ejb-client to 4.x, the related errors are removed during the refracting in jboss-ejb-client master branch(4.x).
So there is no corresponding PR for this issue in master branch.