SSL documentation and related fixes #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
reviewed
Feb 25, 2019
| They enable the native SSL support for your native image. | ||
|
|
||
| As SSL is ipso facto the standard nowadays, we decided to enable its support automatically for some of our extensions e.g. our REST client extension, | ||
| our JDBC drivers extensions... |
There was a problem hiding this comment.
Shouldn't we rather list all of the extentions?
We want to allow the user to override these properties so we don't set them unconditionally. The idea would be to add additional paths to java.library.path but there's something fishy going on with GraalVM: as long as there are more than one paths in java.library.path, GraalVM can't find the library anymore.
stuartwdouglas
approved these changes
Feb 26, 2019
maxandersen
pushed a commit
to maxandersen/quarkus
that referenced
this pull request
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the SSL doc and also a couple of fixes:
java.library.pathandjavax.net.ssl.trustStorepropertiesjava.library.pathwith multiple paths: as soon as there is more than one path, the library is not found (even if the path is just.:/working/path/). I don't have the time to track that one at the moment so for now, I commented the code I want to have and integrated a workaround using only one path.I think it's good enough for now and makes our SSL support usable.