Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong response code if compile fails #1100

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Wrong response code if compile fails #1100

merged 1 commit into from
Mar 1, 2019

Conversation

stuartwdouglas
Copy link
Member

@stuartwdouglas stuartwdouglas commented Feb 28, 2019 •
edited by cescoffier

Fixes #1099

johnaohara
johnaohara approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@johnaohara johnaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think HTTP 500 is the correct response if the application fails to build

@johnaohara
Copy link
Member

The failing test (testThatApplicationRecoversCompilationIssue) passes for me locally

@gsmet gsmet merged commit 78843a4 into quarkusio:master Mar 1, 2019
@gsmet gsmet modified the milestones: 0.10.0, 0.11.0 Mar 1, 2019
@cescoffier cescoffier changed the title Fixes #1099, wrong response code if compile fails Wrong response code if compile fails Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnaohara johnaohara johnaohara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stuartwdouglas @johnaohara @emmanuelbernard @gsmet