Add noverify flag to the JVM for the dev mode #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been hesitant to add this because we are doing bytecode generation, so if we have a bug in our code if this flag is present it will manifest in a JVM crash. As this only applies to dev mode I think this is ok, but we should have an option to re-enable this. |
|
The fact that it only applies to dev mode is also why I think it's ok to add. I would be glad to add a flag to disable this feature. What would you prefer it be called? |
This flag disables bytecode verification and therefore reduces the startup time. Also introduce the preventnoverify maven option that prevents setting the noverify JVM flag Fixes: #340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag disables bytecode verification and therefore reduces the
startup time
Fixes: #340