Remove Undertow dependency from ArC #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
requested changes
Jan 16, 2019
| import org.jboss.builder.item.SimpleBuildItem; | ||
| import org.jboss.protean.arc.ArcContainer; | ||
|
|
||
| public final class ArcContainerBuildItem extends SimpleBuildItem { |
There was a problem hiding this comment.
Hm, I think we should rather extend the BeanContainer. Maybe just expose org.jboss.protean.arc.ArcContainer.withinRequest(Supplier<T>)?
There was a problem hiding this comment.
I have updated this
|
|
||
| public class BeanDefiningAnnotationsBuildStep { | ||
|
|
||
| @BuildStep | ||
| void beanDefiningAnnotations(Capabilities capabilities, BuildProducer<BeanDefiningAnnotationBuildItem> annotations) { | ||
| if (capabilities.isCapabilityPresent(Capabilities.UNDERTOW)) { |
There was a problem hiding this comment.
Capabilities.UNDERTOW is not used anywhere else and could be removed.
stuartwdouglas
force-pushed
the
arc-ut-swap
branch
from
6ed34b0
to
71eb854
Compare
- also do not activate the request context if already active
Make BeanContainer.RequestAction more generic
maxandersen
pushed a commit
to maxandersen/quarkus
that referenced
this pull request
Nov 5, 2022
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.