Only log a warning if GRAALVM_HOME is not set and SSL is enabled #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was an issue prior to my SSL fixes but was hidden as shamrock.ssl.native was never enabled on CI. This is now the case as it can be enabled by default by an extension. For the record, CI currently does not have GRAALVM_HOME set and uses a Docker environment to build native images.
cescoffier
approved these changes
Feb 5, 2019
|
This won't work once GraalVM moves on top of Java 11, there is different directory structure. |
|
@rsvoboda yeah, it's very fragile. Unfortunately, we didn't find a better way to do that right now. It also does not work if you move your binary to another server with a different path to the lib directory. Note that this code has been there since the beginning. I removed it as I thought it wasn't useful anymore as it was working without it on my laptop and then reintroduced it back. |
|
We're basically waiting for graal to support static linking of SSL so we can get rid of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was an issue prior to my SSL fixes but was hidden as
shamrock.ssl.native was never enabled on CI.
This is now the case as it can be enabled by default by an extension.
For the record, CI currently does not have GRAALVM_HOME set and uses a
Docker environment to build native images.