Run tests on a different port #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
devmode
branch
2 times, most recently
from
8b21188
to
45e5cc3
Compare
stuartwdouglas
force-pushed
the
devmode
branch
from
45e5cc3
to
04f0dec
Compare
gsmet
approved these changes
Feb 13, 2019
|
@stuartwdouglas not merging just yet as I don't know if you want to have the random port discussion here. Feel free to merge if not. |
|
@gsmet this was discussed at the meeting yesterday? Recap: Need just to separate the testing port for now. The random port thing is a next-step enhancement, cant wait a bit more. |
|
@Sanne sure but see the issue description :). I approved it, just letting Stuart deciding when he wants to merge it. |
|
I will just merge it for now, if people want to do something different then we can revisit later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gone with 8081, but I am not sure if we should go something really random instead