Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REMJMX-160] Mark the remoting-jmx thread group as a daemon thread group #38

Merged
merged 1 commit into from May 13, 2019

Conversation

msfm
Copy link
Contributor

@msfm msfm commented Apr 8, 2019

A daemon thread group is automatically destroyed when its last thread
is stopped or its last thread group is destroyed.
This can avoid a memory leak by retaining many ThreadGroup objects when
a JMX client repeats creating and closing a connection many times.
@msfm msfm changed the title [REMJMX-160] Do not create a new ThreadGroup for every JMXConnectorFa… [REMJMX-160] Mark the remoting-jmx thread group as a daemon thread group May 10, 2019
@darranl
Copy link
Member

darranl commented May 13, 2019

Is this one really required, the 1.1 branch has not undergone any maintenance for almost five years now.

@msfm
Copy link
Contributor Author

msfm commented May 13, 2019

I think this is required because the original issue was reported against EAP 6.4 which comes with remoting-jmx 1.1 branch. (The latest CP21 comes with remoting-jmx 1.1.3.Final).

I've just added the BZ information to the first comment.

@darranl
Copy link
Member

darranl commented May 13, 2019

Ok I will see if we get sufficient ACKs to merge.

@darranl darranl merged commit e8dff0c into jbossas:1.1 May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants