New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBTM-3624 JBTM-3626 JacORB (and don't provide OpenJDK to JacORB compiler classpath JBTM-3590) #1993
Conversation
Started testing this pull request with QA_JTS_JACORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/920/ |
Started testing this pull request with CORE profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/920/ |
Started testing this pull request with QA_JTS_OPENJDKORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk11.latest,label=linux/920/ |
QA_JTS_JACORB profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/920/): some qa tests failed |
Started testing this pull request with AS_TESTS profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk11.latest,label=linux/920/ |
QA_JTS_OPENJDKORB profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk11.latest,label=linux/920/): some qa tests failed |
AS_TESTS profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk11.latest,label=linux/920/): AS tests failed |
Started testing this pull request with QA_JTS_JACORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/921/ |
Started testing this pull request with QA_JTS_OPENJDKORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk11.latest,label=linux/921/ |
Started testing this pull request with CORE profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/921/ |
Started testing this pull request with AS_TESTS profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk11.latest,label=linux/921/ |
276f4d5
to
fc614ab
Compare
Started testing this pull request with QA_JTS_JACORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/922/ |
Started testing this pull request with CORE profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/922/ |
CORE profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/921/): narayana build failed |
CORE profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/920/): narayana build failed |
Started testing this pull request with AS_TESTS profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk11.latest,label=linux/922/ |
Started testing this pull request with QA_JTS_OPENJDKORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk11.latest,label=linux/922/ |
AS_TESTS profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk11.latest,label=linux/922/): AS tests failed |
QA_JTS_JACORB profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/922/ |
QA_JTS_OPENJDKORB profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk11.latest,label=linux/922/ |
I think the QA_JTS side could be OK, the CORE is hanging |
fc614ab
to
28270b7
Compare
I think the CORE profile when supposed to be using openjdk-orb is maybe using JacORB somehow |
Started testing this pull request with QA_JTS_JACORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/924/ |
Started testing this pull request with CORE profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/924/ |
Started testing this pull request with QA_JTS_OPENJDKORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk11.latest,label=linux/924/ |
Started testing this pull request with AS_TESTS profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk11.latest,label=linux/924/ |
QA_JTS_JACORB profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/942/): some qa tests failed |
The QA_JTS_JACORB profile failed when using JacORB 3.7:
The results are for these cases that we are now receiving a
https://github.com/jbosstm/narayana/blob/master/qa/tests/src/org/jboss/jbossts/qa/OTSServerClients/Client04.java#L122 https://github.com/jbosstm/narayana/blob/master/qa/tests/src/org/jboss/jbossts/qa/OTSServerClients/Client05.java#L122 https://github.com/jbosstm/narayana/blob/master/qa/tests/src/org/jboss/jbossts/qa/OTSServerClients/Client06.java#L122
|
Perhaps the differences in behaviour in the QA tests could be attributed to not using the special patched version of JacORB, what do you think @mmusgrov? |
Started testing this pull request with QA_JTS_JACORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/956/ |
Started testing this pull request with CORE profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/956/ |
CORE profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/956/): narayana build failed |
3a98d86
to
6c57c36
Compare
6c57c36
to
6d85d29
Compare
Started testing this pull request with QA_JTS_JACORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/962/ |
6d85d29
to
28c6941
Compare
Started testing this pull request with QA_JTS_JACORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/964/ |
QA_JTS_JACORB profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/962/): some qa tests failed |
QA_JTS_JACORB profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk11.latest,label=linux/964/): some qa tests failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am provisionally approving this PR subject to the understanding that:
1 The four test failures are due to the change in jacorb semantics of the after synchroniztion and that this PR will be quickly followed up with a PR from @jmfinelli to remove JacORB completely;
2 The PR is re-tested on at least the CORE axis. I did run it successful on my laptop but it will do no harm retesting on the PR;
3 And an observation - the Requirements
section in the top level README.md still says that to build narayana it's not sufficient to use a JRE because the build requires access to an IDL compiler so ensure that the JAVA_HOME environment variable is set correctly ...
[1] [main] INFO Transformer - Input does not exist [ /home/mmusgrov/src/forks/narayana/narayana/XTS/localjunit/unit/target/classes ] [ /home/mmusgrov/src/forks/narayana/narayana/XTS/localjunit/unit/target/classes ]
I was holding the PR to remove JacORB as there were a couple of PRs interfering wth the modifications needed to remove JacORB. Those PRs got merged today so I can now rebase my branch on top of |
@jmfinelli I would suggest to ensure that you either rebase your branch on top of my more-JBTM-3590 branch so you know you can merge it after mine and that it should apply cleanly or you just take the commits from this PR into your own PR and we close this one. Or you leave your PR without any connection to this PR and then try your rebase. We could revert this PR then if there were some problem. In terms of the README.md as it's not connected to JacORB I think we should have a separate PR for that. In terms of running CORE again, I will trigger it for this PR |
PR for the README.md update: #2000 |
Started testing this pull request with CORE profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/967/ |
CORE profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/967/ |
28c6941
to
510605b
Compare
Started testing this pull request with CORE profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/970/ |
CORE profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk11.latest,label=linux/970/ |
We should consider closing this PR and merging #2001 (assuming changes from this PR are in there) so that the removal can be merged in the same PR |
+1 |
Consolidate the versions of JacORB: https://issues.redhat.com/browse/JBTM-3624
CORE !TOMCAT !AS_TESTS !RTS !JACOCO !XTS !QA_JTA
!QA_JTS_JACORB
!QA_JTS_JDKORB !QA_JTS_OPENJDKORB !PERF !LRA !DB_TESTS mysql db2 postgres oracle
Also includes a commit to deal with modular.jdk.args which should no longer be required since https://issues.redhat.com/browse/JBTM-3590 but the way I changed it also changes QA_JTS_JDKORB QA_JTS_OPENJDKORB. That change should be tested here and #1995